Repository navigation
Match the volume slider to the brightness slider - #271
Merged
Merged
Conversation
On macOS 27 the brightness slider uses the regular control size to match Control Center, but the volume slider under it stayed small, so it had a thinner track and knob. It now follows the same rule: regular on macOS 27, small on 26 and earlier. The two tracks also started and ended at different places, because the speaker icons are wider than the sun icons (speaker.wave.3.fill is 24pt at this size, sun.max.fill is 19pt). Every step button icon now sits in a 24pt frame, so the tracks line up. The brightness tracks are a few points shorter as a result. Checked on macOS 27 with an external monitor that has DDC volume.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS 27 the brightness slider uses the regular control size to match Control Center, but the volume slider under it stayed small, so it had a thinner track and knob. It now follows the same rule: regular on macOS 27, small on 26 and earlier.
The two tracks also started and ended at different places, because the speaker icons are wider than the sun icons (speaker.wave.3.fill is 24pt at this size, sun.max.fill is 19pt). Every step button icon now sits in a 24pt frame, so the tracks line up. The brightness tracks are a few points shorter as a result.
Checked on macOS 27 with an external monitor that has DDC volume.